Closed majesticio closed 7 months ago
results:
There are 1 unused packages:
⚠⚠⚠⚠⚠⚠⚠⚠⚠
Unused dependencies:
- knex
I am going to remove the unused dependency (knex)
I have removed all of the unused files, I need to investigate the use of API_URL in deploy.yml to fetch GH secrets
I have removed all of the unused files, I need to investigate the use of API_URL in deploy.yml to fetch GH secrets
Ignore anything in github action. All this clean up is agnostic of whats happning in Github Actions
@majesticio Where are we standing on this branch?
This should be good to go, but I will need to adjust it to accommodate our recent changes
My comments were never addressed re:API_URL and WEBHOOK_KEY These are not actively used and need to be cleaned up
I will get those taken care of.
API_URL
and WEBHOOK_KEY
have been removed and merge conflicts with main resolved.
@caparker it ran identically for me, and finished a few seconds faster. I am concerned if it does not work on your end
I’ll take a closer look on my end. May have just been a fluke .
On Fri, Mar 22, 2024 at 11:59 AM Gabriel Fosse @.***> wrote:
@caparker https://github.com/caparker it ran identically for me, and finished a few seconds faster. I am concerned if it does not work on your end
— Reply to this email directly, view it on GitHub https://github.com/openaq/openaq-fetch/pull/1080#issuecomment-2015728919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOE5OWL6TXJ3S5IRDW22U3YZR5SHAVCNFSM6AAAAABDATO62WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVG4ZDQOJRHE . You are receiving this because you were mentioned.Message ID: @.***>
cleaned up env.js and removed knexfile Dockerfile and associated docs