openbao / openbao-helm

Helm chart to install OpenBao and other associated components.
Mozilla Public License 2.0
7 stars 3 forks source link

Issue 6: Changed some of the Hashicorp Vault references in the docs to OpenBao #7

Closed naphelps closed 1 month ago

naphelps commented 1 month ago

References: #6

Changes:

naphelps commented 1 month ago

@JesseBot Some doc changes. Cleaned up 1 or 2 items that got missed in your pull request.

jessebot commented 1 month ago

So, we kinda have an issue where even after you bump the chart version, the chart linter will still fail, because there's a few things left over from hashicorp that need to be fixed to please the linter in values.yaml:

I've addressed all of the above in https://github.com/openbao/openbao-helm/pull/8 so you can still do one of the following:

  1. force merge this, then I can pull the changes to my fork's main branch, then rebase and force push to my feature branch, and then the tests should pass in my #8 and we can merge that into main for this repo

  2. open a PR from with these changes, naphelps:issue-6, to my feature branch in #8, I merge them into my feature branch, and then we merge #8 in

3. I can open a PR to naphelps:issue-6, you can merge my feature branch into naphelps:issue-6, and then we merge this PR into main. Can't do this, GitHub doesn't let me open a PR to that fork for some reason :shrug: