search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
137 stars 52 forks source link

Small fixes [for case of packet fragmentation] #102

Closed baffo32 closed 7 years ago

baffo32 commented 7 years ago

These adjustments allow the tests to pass if #101 is merged or used.

Incidentally also fixes some initialization issues when communicating with a real live board.

codecov-io commented 7 years ago

Current coverage is 93.53% (diff: 100%)

Merging #102 into 1.4.0 will increase coverage by <.01%

@@              1.4.0       #102   diff @@
==========================================
  Files             4          4          
  Lines          2180       2181     +1   
  Methods         126        126          
  Messages          0          0          
  Branches        475        475          
==========================================
+ Hits           2039       2040     +1   
  Misses          141        141          
  Partials          0          0

Powered by Codecov. Last update 7d78748...cc4afcd

baffo32 commented 7 years ago

Just fixes, not tests.

Sorry, I guess this should probably be on top of #101. The two relevant fixes are still applicable without #101, they just don't change any test results without it. I am still learning about latency timers etc to possibly rework #101 to emulate the chip better.

andrewjaykeller commented 7 years ago

I'm surprised this passed tests because fragmentation is not in master

baffo32 commented 7 years ago

will rebase onto #100