openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
137 stars 52 forks source link

Throw an error if invalid options are passed #108

Closed baffo32 closed 7 years ago

baffo32 commented 7 years ago

It's a good thing I make so many mistakes, so I can write checks to detect them.

Ready for merge.

codecov-io commented 7 years ago

Current coverage is 93.72% (diff: 100%)

Merging #108 into 1.4.0 will increase coverage by 0.06%

@@              1.4.0       #108   diff @@
==========================================
  Files             4          4          
  Lines          2207       2214     +7   
  Methods         128        128          
  Messages          0          0          
  Branches        467        467          
==========================================
+ Hits           2067       2075     +8   
+ Misses          140        139     -1   
  Partials          0          0          

Powered by Codecov. Last update de57563...2d1285a

andrewjaykeller commented 7 years ago

Please update changeLog.md with new name. Please code indicators (back ticks) in the change log so the line would be:

Three new initialization options: simulatorFragmentation , simulatorBufferSize, and simulatorLatencyTimer. Together, these new options enable a more realistic simulator, mimicking different potential user computer systems.

something like that please, so people can read the change log and know where to look. Thanks! Once again love the new features flowing in!

baffo32 commented 7 years ago

changelog updated !