Writes resolve promises

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards

https://www.npmjs.com/package/openbci

137 stars 52 forks source link

Writes resolve promises #116

Closed baffo32 closed 7 years ago

baffo32 commented 7 years ago

Closes #91 . This PR goes on top of #111 and changes the behavior of the write() call such that the promise it returns is only resolved after the write has been sent, including any configured delay. The promise is rejected in case of a write error or disconnection.

baffo32 commented 7 years ago

test failures are all #115 again

codecov-io commented 7 years ago

Current coverage is 94.01% (diff: 94.28%)

Merging #116 into 1.4.0 will decrease coverage by 0.41%

@@              1.4.0       #116   diff @@
==========================================
  Files             4          4          
  Lines          2263       2257     -6   
  Methods         135        132     -3   
  Messages          0          0          
  Branches        484        482     -2   
==========================================
- Hits           2137       2122    -15   
- Misses          126        135     +9   
  Partials          0          0

Powered by Codecov. Last update c4e29bb...b3a61b4

andrewjaykeller commented 7 years ago

Can you please change the base branch to development? I'm so sorry, i did not realize deleting that branch would close this PR!

baffo32 commented 7 years ago

hrm I did this but it doesn't reopen it !

andrewjaykeller commented 7 years ago

this is very strange ok well good thing we are switching to a development branch hahah

andrewjaykeller commented 7 years ago

can you try to make a new pull request?