openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
137 stars 52 forks source link

Lab Streaming Layer example #139

Closed gabrielibagon closed 7 years ago

gabrielibagon commented 7 years ago

I figured it would be good to add an example of working code for streaming through LSL using the NodeJS SDK . This uses a modified version of the NodeJS -> Python technique shown in the other example file. The code is ready to stream as-is, which should make this directory useful for people who would like to just start streaming on LSL right away.

Equivalent code for the ganglion is mostly written using the same technique (though I'm running into the roadblock in this Ganglion issue!) If this looks good to you, I'll post a pull request there once it's done.

codecov-io commented 7 years ago

Codecov Report

Merging #139 into development will decrease coverage by -0.31%. The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #139      +/-   ##
===============================================
- Coverage        94.45%   94.14%   -0.31%     
===============================================
  Files                4        4              
  Lines             2290     2290              
  Branches           494      494              
===============================================
- Hits              2163     2156       -7     
- Misses             127      134       +7
Impacted Files Coverage Δ
openBCISample.js 92.08% <ø> (-1.14%) :x:
openBCIBoard.js 93.63% <ø> (-0.22%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d7547c...98298f7. Read the comment docs.

andrewjaykeller commented 7 years ago

@gabrielibagon

  1. This is awesome!
  2. Should we remove https://github.com/OpenBCI/OpenBCI_NodeJS#-interfacing-with-other-tools and link to the example you wrote?
  3. Ganglion issue https://github.com/OpenBCI/OpenBCI_NodeJS_Ganglion/issues/23 has been closed and you may continue your development!
  4. I see no issue with merging this, I just want to add more links to this in the main readme
andrewjaykeller commented 7 years ago

Yessss good work Gabe!!!!

gabrielibagon commented 7 years ago

Woo, thanks! Documentation should be finished. I'll be using this a ton over the next week or two, so I'll be keeping an eye out for any issues that pop up.

andrewjaykeller commented 7 years ago

@gabrielibagon great job! merged!