search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
137 stars 52 forks source link

ADD Auto test #22

Closed andrewjaykeller closed 8 years ago

andrewjaykeller commented 8 years ago

Fully documented and described in detail, you can now automatically get the impedances of all channels and inputs.

teonbrooks commented 8 years ago

you should squash e8a273c263778594b5069415b8f5acaf2cf391e6 in your history

andrewjaykeller commented 8 years ago

And now there are conflicts :(

andrewjaykeller commented 8 years ago

I'm closing this request because i have to re work the interface.... After talking with Joel, additional things need to be done:

  1. ENH functionality to specify which input you want to test, it does not make sense to always test both.
  2. ADD outlier identification, in the impedance samples, there is the potential to get an extreme outlier, such 59/60 samples oscillate around 5k Ohm, and then one sample has 2983456 k Ohms which destroys the average impedance, indicating the channel is bad, when really it can be good.
  3. ENH The impedance object needs to output and array of objects, not an object of objects
teonbrooks commented 8 years ago

I will review the reworked tout de suite when you reopen. I am flying back tomorrow morning and will be aching to review some code ;)