search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
137 stars 52 forks source link

impedance testing not operating properly #28

Closed andrewjaykeller closed 7 years ago

andrewjaykeller commented 8 years ago

The values that come back from an electrode are too high. There is an issue.

andrewjaykeller commented 8 years ago

Well @andrewheusser i wanted to add @teonbrooks here too. I need your help with this! So I have it mainly working, on my dev branch. However all I need to do is taken an FFT at 31.5Hz and use the intensity at that bin as the voltage. I would really love some help with this and this seems right up your guys wheel house. I can teach you how to do the automated testing to get it working and such too!

EDIT: The first sentence I meant as I wanted to add Teon as an assignee haha

andrewheusser commented 8 years ago

@pushtheworldllc : going in tomorrow? lets take a look then

andrewjaykeller commented 8 years ago

No unfortunately I am heading down to southern jersey for easter weekend but I will be online and can definitely have a google hangout!

andrewheusser commented 8 years ago

@pushtheworldllc hey I need a little more context here...where do we want to add an FFT?

andrewjaykeller commented 8 years ago

We want to use an FFT to get the amplitude of the channel voltage at 31.5Hz because that’s the frequency of the impedance test signal. Does that make sense?

AJ

From: Andy Heusser notifications@github.com Reply-To: OpenBCI/openbci-js-sdk reply@reply.github.com Date: Wednesday, March 30, 2016 at 6:12 AM To: OpenBCI/openbci-js-sdk openbci-js-sdk@noreply.github.com Cc: Andrew Keller pushtheworldllc@gmail.com Subject: Re: [OpenBCI/openbci-js-sdk] impedance testing not operating properly (#28)

@pushtheworldllc hey I need a little more context here...where do we want to add an FFT?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

andrewjaykeller commented 8 years ago

Where we want to add it is in the calculation of impedances!

From: Andy Heusser notifications@github.com Reply-To: OpenBCI/openbci-js-sdk reply@reply.github.com Date: Wednesday, March 30, 2016 at 6:12 AM To: OpenBCI/openbci-js-sdk openbci-js-sdk@noreply.github.com Cc: Andrew Keller pushtheworldllc@gmail.com Subject: Re: [OpenBCI/openbci-js-sdk] impedance testing not operating properly (#28)

@pushtheworldllc hey I need a little more context here...where do we want to add an FFT?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

andrewheusser commented 8 years ago

@pushtheworldllc i understand that, can you point me to the point in the code where it should be implemented?

andrewjaykeller commented 8 years ago

https://github.com/pushtheworldllc/openbci-js-sdk/blob/dev/openBCISample.js#L215-L237

Please fork my branch if possible! There are a bunch of changes, getting ready for a 0.3

andrewheusser commented 8 years ago

ok will do...hmmm, I'm not sure it makes sense to put it here since an FFT requires multiple time points to compute. How will computing an FFT help with the impedance estimates anyway?

andrewjaykeller commented 8 years ago

See PR #32 for version 0.3.0 for major changes leading to the resolution of this bug. Need to test.

andrewjaykeller commented 7 years ago

Reopening issue due to #131

andrewjaykeller commented 7 years ago

Final going to close this soon