search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
137 stars 52 forks source link

Node 5 compatibility #31

Closed andrewjaykeller closed 8 years ago

andrewjaykeller commented 8 years ago

The serialport dependency does not work on node 4

andrewjaykeller commented 8 years ago

Looks like Serialport will be updating soon https://github.com/voodootikigod/node-serialport/issues/688

reconbot commented 8 years ago

Serialport does work on node 4 and 5 btw

teonbrooks commented 8 years ago

@reconbot I think we had a typo above, we've had it work with v4 but v5 of Node would cause the crash. are you saying that it is fine for v5?

reconbot commented 8 years ago

We currently test in v0.10-5 on Mac, Linux, and windows for nodejs. Electron apps can be made to work but don't seem to out of the box.

Node 6 and better Electron support are in the near future.

On Sun, Apr 3, 2016, 12:36 AM Teon L Brooks notifications@github.com wrote:

@reconbot https://github.com/reconbot I think we had a typo above, we've had it work with v4 but v5 of Node would cause the crash. are you saying that it is fine for v5?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/OpenBCI/openbci-js-sdk/issues/31#issuecomment-204866352

andrewjaykeller commented 8 years ago

@reconbot what is your suggested fix for this issue 

Error: Cannot find module '/Users/ajk/BCI/openbci-js-sdk/node_modules/serialport/build/Release/node-v47-darwin-x64/serialport.node'

In my electron application i am using a script that looks like "preinstall": "electron-rebuild -v 0.36.9 -p -f -w serialport -e node_modules/electron-prebuilt" and that seems to solve this issue. Thanks!!

andrewjaykeller commented 8 years ago

Fixed #32