search

openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
137 stars 52 forks source link

ADD SD card support functions #60

Closed andrewjaykeller closed 8 years ago

andrewjaykeller commented 8 years ago

Added user facing functions to provide SD card logging support

teonbrooks commented 8 years ago

I don't see where the command to write to the SD card plays in.

codecov-io commented 8 years ago

Current coverage is 84.91%

Merging #60 into master will increase coverage by 0.50%

@@             master        #60   diff @@
==========================================
  Files             4          4          
  Lines          1384       1471    +87   
  Methods          97         99     +2   
  Messages          0          0          
  Branches        260        288    +28   
==========================================
+ Hits           1168       1249    +81   
- Misses          216        222     +6   
  Partials          0          0

Powered by Codecov. Last updated by 9717877...20ccf61

teonbrooks commented 8 years ago

other than comment out question, LGTM

andrewjaykeller commented 8 years ago

Good catch. I'm squashed into one commit and it lgtm

teonbrooks commented 8 years ago

just noticed something, the unit test didn't pick up on that...

andrewjaykeller commented 8 years ago

That should not cause an error. That is how that type of comment should be interpreted by the compiler.

teonbrooks commented 8 years ago

ah, it was the trailing comment, not the opening one. got it