openbci-archive / OpenBCI_NodeJS

Node.js SDK for the all OpenBCI Biosensor Boards
https://www.npmjs.com/package/openbci
137 stars 52 forks source link

Commands with responses resolve early #97

Closed baffo32 closed 7 years ago

baffo32 commented 7 years ago

Commands that return data should not resolve until they can resolve with the return value.

Implementing this may involve reviewing and re-evaluating the current 'state-based' approach to reading data; or it may be straightforward to include.

andrewjaykeller commented 7 years ago

@baffo32 any idea what we can do to merge this in? I'm looking to get 1.4.1 merged in ASAP, has a couple good bug fixes.

baffo32 commented 7 years ago

I haven't started this yet; I don't feel I have a good enough handle yet on all the responses that can come from the board. I was really on a roll when I opened this issue, but less time has been available to me more recently.

andrewjaykeller commented 7 years ago

This was completed.