openbmc / dbus-sensors

D-Bus configurable sensor scanning applications
Apache License 2.0
27 stars 45 forks source link

README.md hyperlink ExternalSensor returns a 404 ERROR #13

Closed ghost closed 3 years ago

ghost commented 3 years ago

ExternalSensor virtual sensor returns a 404 ERROR.

Also note there already exists a virtual-sensors.md in the docs/design folder. Maybe virtual sensor, after ExternalSensor, should have different wording.

edtanous commented 3 years ago

did this link get fixed?

ghost commented 3 years ago

No, just check I still get 404 ERROR.

ghost commented 3 years ago

I feel like this needs to be assigned to Josh Lehan Krellan, based off of when I found the issue. But I do not have the permissions to do so.

williamspatrick commented 3 years ago

The issue is that the design was never merged in docs. https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/41452 I just merged it so this can probably be closed.

ghost commented 3 years ago

Thank you Patrick (and Josh for writing it), that does resolve this issue!