search

openbmc / docs

OpenBMC Documentation
Creative Commons Attribution 4.0 International
267 stars 305 forks source link

Host poweroff: Removed extra slash on URL #54

Closed loerac closed 2 years ago

loerac commented 4 years ago

While @JPalacios14 and I were trying some of the examples, specifically the "Host hard power off" curl example, we kept getting a "Not Found" error. This was due to the fact that there was two "//" after "${bmc}" i.e. https://${bmc}//xyz/openbmc_project/state/chassis0/attr/RequestedPowerTransition. This change removes the extra '/' and we are able to get an OK status response.

williamspatrick commented 4 years ago

@loerac , @JPalacios14 - Thanks for identifying this problem.

Two comments:

  1. We don't actually use Github for development but use a Gerrit server at https://gerrit.openbmc-project.xyz/q/status:open and we automatically mirror content from Gerrit to Github. We cannot accept PRs from Github because the sync is one-way (Gerrit -> Github).

https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#submitting-changes-via-gerrit-server-to-openbmc

  1. I don't recognize either of you as having contributing to OpenBMC before (Great to have new people!). The organization of the project requires Contributor License Agreements from contributors. There are corporate and individual CLAs depending on if you are doing work on behalf of your employer or as individuals.

For a small documentation change like this, I would probably allow it in without a CLA, but for any code of significance we currently need one. It is possible you are already covered by your employer's CLA and I simply don't recognize your names.

(Instructions on CLA are also covered in the CONTRIBUTING link above.)

williamspatrick commented 3 years ago

@loerac - Any update on the above?

williamspatrick commented 2 years ago

We don't acccept PRs. No response from contributor in a year.