search

openbridge / ob_php-fpm

PHP-FPM container for NGINX using Alpine, Opcache, Dynamic Resources, Monitoring, Security
https://www.openbridge.com
MIT License
96 stars 26 forks source link

Adds PHP 7.4 #31

Closed marcortola closed 3 years ago

marcortola commented 3 years ago

Alpine 3.13 has just been released, and it natively supports PHP 7.4 and PHP 8. This PR allows switching between Alpine versions for installing specific PHP versions.

I don't know if you use shippable.yml to push builds to Dockerhub. If so, this PR shows a sample of how to adapt the build process to PR changes.

tspicer commented 3 years ago

HI, thanks for this. This would be a breaking change as any build would require the version to be passed as part of the build process itself. I need to look at this more closely to understand the impacts/alternative.

marcortola commented 3 years ago

Perfect. I forgot to add a default value to the ARG. That would solve that problem, but I haven't tried anything else, and there could be other side effects.

tspicer commented 3 years ago

Perfect. I forgot to add a default value to the ARG. That would solve that problem, but I haven't tried anything else, and there could be other side effects.

if you want to update with the change I can test it.