search

opencaching / okapi

A common API for all National Opencaching.XX sites
22 stars 20 forks source link

ACODE duplicates #590

Closed andrixnet closed 4 years ago

andrixnet commented 5 years ago

How would be the best recommended way to resolve the following ACODE duplicates?

A40 references

        <opencaching schema="OCDE" id="39" />
        <opencaching schema="OCNL" id="39" />
        <opencaching schema="OCRO" id="39" />
        <opencaching schema="OCUK" id="39" />

A73 references

        <opencaching schema="OCPL" id="80" />
        <opencaching schema="OCRO" id="80" />

References in A73 are wrong. OCPL and OCRO id=80 is a different attribute. Hence this ACODE remains empty. How is this to be handled?

  1. leave empty?
  2. delete it?
  3. reassign it to other attribute?

A70 references 

        <opencaching schema="OCPL" id="41" />
        <opencaching schema="OCNL" id="41" />

A71 references 

        <opencaching schema="OCDE" id="59" />
        <opencaching schema="OCRO" id="59" />
        <opencaching schema="OCUK" id="59" />

While the name and description vary slightly, the meaning is the same. How should this be handled?

  1. merge into A70 and handle A71 same as A40/73
  2. other ?

Thank you.

harrieklomp commented 5 years ago

My suggestions are based on the number of databases that need to be updated. Also there is a chance that OCDE does not change their database.

following5 commented 5 years ago

Yes, A73 now seems to be obsolete, since I did some cleanup of OCPL attributes.

Hence this ACODE remains empty. How is this to be handled?

Reassign ID 80 in OKAPI attribute-definitions.xml to A40, but keep A73 for backward compatibility. OKAPI will then mark A73 as "discontinued".

A70 and A71 are different:

We map both the the same GC attribute, because there is no better way to map it.

following5 commented 5 years ago

@harrieklomp This can only be changed in OKAPI code; OCPL code or database does not know about A40 or A73. It's just ID 80 there.

following5 commented 5 years ago

A70 = Suited for small children. A71 = Suited for 10-12 years old children.

... theoretically. Practically, many user's wont care about this detail and just assign the attribute to anything they associate with "children". But that's nothing we can do about at OKAPI project; we just reflect the attribute definitions chosen by OCDE and OCPL developers.

harrieklomp commented 5 years ago

@following5

This can only be changed in OKAPI code; OCPL code or database does not know about A40 or A73. It's just ID 80 there.

For the changing the code and/or database we need to open a issue on https://github.com/opencaching/opencaching-pl

andrixnet commented 5 years ago

see also https://github.com/opencaching/opencaching-pl/issues/1251

andrixnet commented 5 years ago

As part of https://github.com/opencaching/opencaching-pl/issues/1251 I will also update attributes.xml in OKAPI and make a pull request.

andrixnet commented 5 years ago

Question: is this distinction important / significant for both OC node operators (rules) and geocachers?

A70 = Suited for small children. A71 = Suited for 10-12 years old children.

IMO OCRO should be at A70. I believe UK might say the same thing.

I mean, is this age range significant in any practical sense or was it some intent at some time in the past and remained as such in the translation?

Let me put it another way: How does OCDE consider caches with this attribute regardign children 9 years or 13 years old?

following5 commented 5 years ago

I mean, is this age range significant in any practical sense

The 10-12 years range was defined on purpose this way by OCDE developers (long time ago), after discussing which attribute definition would be most useful. It is defined this way on the OCDE website. We would break OCDE semantics if we redefine it in Okapi, therefore we should not do that.

following5 commented 5 years ago

FYI, I am no member of OCDE team for a while now, and OCDE development is almost dead. From the Okapi side, I think we can consider OCDE as a static legacy which we need to stay backward compatible to.

andrixnet commented 5 years ago

Understood, thank you.

andrixnet commented 5 years ago

Solved by https://github.com/opencaching/okapi/pull/591

andrixnet commented 4 years ago

This issue has been solved and can be closed.