openclimatefix / PVNet

PVnet main repo
MIT License
15 stars 3 forks source link

Remove references to old datamodule config parameters #163

Closed Sukh-P closed 3 months ago

Sukh-P commented 3 months ago

Pull Request

Description

Removing references in the example config files to old datamodule config parameters (n_train_data and n_val_data) which are no longer used in the datamodule class (limiting number of batches is done through the trainer config parameters instead i.e limit_train_batches)

This is to make it slightly clearer when looking at the examples what parameters are still in use.

Checklist:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.47%. Comparing base (27f16c5) to head (cc75c26).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #163 +/- ## ======================================= Coverage 61.47% 61.47% ======================================= Files 28 28 Lines 1786 1786 ======================================= Hits 1098 1098 Misses 688 688 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.