opencollab / jlatexmath

A Java API to render LaTeX
Other
514 stars 109 forks source link

Rewrite the parser #27

Closed calixteman closed 3 years ago

calixteman commented 7 years ago

Right now, the parser is slow, bad-designed. So the goal is to have something very fast but it requires to rewrite parser itself and rewrite almost all the macros which take some strings as arguments rather than atom.

davidmoten commented 7 years ago

Sounds good. If you like I can contribute jmh benchmarks so you can measure the performance now before changes. I use them in other projects by calling mvn clean install -P benchmarks. I would add a sample benchmark that measures the perf of parsing and then rendering to a BufferedImage and you would be able to add whatever additional benchmarks you felt like.

Just before you start doing significant work across the code base I thought to sneak in a PR with a bit of cleanup like removing unused imports, unused constants, add generic types where missing. Just addressing the warnings that an IDE like Eclipse tells you about. Should I wait till later or is now an ok time?

calixteman commented 7 years ago

Go ahead :) Please make your PR asap.

davidmoten commented 7 years ago

@calixteman @sylvestre there are a few changes committed that haven't been released. Shall we release 1.0.6 now?

calixteman commented 7 years ago

Yes please

calixteman commented 7 years ago

Oh my bad, I closed a non-fixed bug...

davidmoten commented 7 years ago

1.0.6 is up on Maven Central. Will be dowloadable in ~10min and indexed by search engines in ~2 hours. I've updated the Releases page too.

murkle commented 6 years ago

done here: https://github.com/opencollab/jlatexmath/tree/experimental