search

opencollab / jlatexmath

A Java API to render LaTeX
Other
514 stars 109 forks source link

Use a scale factor of 100 for deriveFont(); fixes #32 #37

Closed vlad-ivanov-name closed 6 years ago

vlad-ivanov-name commented 6 years ago

See #32

There's a tabs/spaces mixup in CharBox.java that needed to be cleared, so the diff is a bit larger than it needs to be

sylvestre commented 6 years ago

Thanks for the patch. In the future, please don't mix changes!

vlad-ivanov-name commented 6 years ago

For what it's worth I think a general indentation cleanup is needed because there are a lot of files like this and a lot of trailing spaces too.

sylvestre commented 6 years ago

Could you please detail the change in https://github.com/opencollab/jlatexmath/blob/master/CHANGELOG ? Thanks

vlad-ivanov-name commented 6 years ago

Should I add version 1.0.7?

sylvestre commented 6 years ago

yes please!

davidmoten commented 6 years ago

Can deploy a release whenever you want @sylvestre

sylvestre commented 6 years ago

I wonder if this isn't a bit overkill for just this small change?

vlad-ivanov-name commented 6 years ago

While it's small it's significant, I use package from maven at work and I'm sure some other people would be happy to upgrade too.

murkle commented 6 years ago

Yes, small change but big bug!

vlad-ivanov-name commented 6 years ago

Would appreciate if the version would be published because now there are several other fixes too.

calixteman commented 6 years ago

@resetnow ok @davidmoten could you deploy a new version please ?

davidmoten commented 6 years ago

@calixteman 1.0.7 has been deployed to Maven Central