search

openconfig / gnoi

gRPC Network Operations Interface (gNOI) defines a set of gRPC-based microservices for executing operational commands on network devices.
Apache License 2.0
160 stars 70 forks source link

Inconsistent specification of Ping count of 0 #60

Closed greg-dennis closed 2 years ago

greg-dennis commented 2 years ago

In the doc of the Ping RPC is says "If a packet count is not explicitly provided, 5 is used": https://github.com/openconfig/gnoi/blob/master/system/system.proto#L39

In the doc of PingRequest it says "A count of 0 defaults to a vendor specified value, typically 5." https://github.com/openconfig/gnoi/blob/master/system/system.proto#L172

So must a count of zero use 5 or is it really left up to the vendor?

Regardless, I recommend removing any mention of the count from the RPC itself, so that the code only contains one source of truth for what a zero count means.

marcushines commented 2 years ago

Going to remove the line in the rpc spec