search

openconfig / gnoi

gRPC Network Operations Interface (gNOI) defines a set of gRPC-based microservices for executing operational commands on network devices.
Apache License 2.0
160 stars 70 forks source link

healthz.proto response should be streaming type #64

Closed amanand closed 2 years ago

amanand commented 2 years ago

In order to export core files or large outputs like "show tech-support" as part of the RPC response, shouldn't the rpc be server streaming type? https://github.com/openconfig/gnoi/blob/7dd3a95a4f1ee589048ac8ebe6ac84c154c152df/healthz/healthz.proto#L43

marcushines commented 2 years ago

Addressed in the streaming healthz PR https://github.com/openconfig/gnoi/pull/79