openconfig / models-ci

Continuous integration for OpenConfig models.
Apache License 2.0
1 stars 0 forks source link

Add check for trailing whitespace #53

Closed aashaikh closed 3 years ago

aashaikh commented 3 years ago

Add a check in the OpenConfig linter (or a dedicated check) to detect and flag trailing whitespace in yang modules on each commit in PR. Authors should fix before merging a PR in the models repo.

wenovus commented 3 years ago

Do you want this check to apply to all files or just modified files? Doing the former would be easy, and we can do that by first cleaning up all existing whitespaces.

wenovus commented 3 years ago

public repo YANG files that have trailing whitespaces:

./third_party/ietf/iana-if-type.yang
./release/models/stp/openconfig-spanning-tree-types.yang
./release/models/isis/openconfig-isis-lsp.yang
./release/models/multicast/openconfig-pim.yang
./release/models/platform/openconfig-platform-software.yang
./release/models/platform/openconfig-platform-port.yang
./release/models/interfaces/openconfig-if-ethernet.yang
./release/models/bfd/openconfig-bfd.yang
./release/models/network-instance/openconfig-network-instance-types.yang
./release/models/bgp/openconfig-bgp-peer-group.yang
./release/models/firewall/openconfig-fw-link-monitoring.yang
./release/models/firewall/openconfig-fw-high-availability.yang