Closed wenovus closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
cmd_gen/main.go | 0 | 1 | 0.0% | ||
commonci/github.go | 0 | 4 | 0.0% | ||
<!-- | Total: | 0 | 5 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
cmd_gen/main.go | 1 | 30.42% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 6819486632: | -0.2% |
Covered Lines: | 939 |
Relevant Lines: | 1726 |
Should we keep both ygot and ygnmi? What's the logic for replacing ygot? (It seems like they do different jobs, and may have different flags/ways of generating structs -- e.g., uncompressed vs. compressed).
Should we keep both ygot and ygnmi? What's the logic for replacing ygot? (It seems like they do different jobs, and may have different flags/ways of generating structs -- e.g., uncompressed vs. compressed).
ygnmi generates a full set of ygot GoStructs with the recommended set of flags for ygot. This is because users of ygnmi in general need the full ygot functionality.
However, there are small benefits to running ygot alongside ygnmi:
I didn't consider the last point here, and that seems to me like a good-enough reason to warrant the extra compute time, so let me add it as a second check.
@robshakir @dplore PTAL.
Tested @ https://github.com/openconfig/public/pull/996 (see latest commits)