openconfig / models-ci

Continuous integration for OpenConfig models.
Apache License 2.0
1 stars 0 forks source link

Do not report type updates as invalid when incompatibilities are allowed #94

Closed wenovus closed 1 year ago

wenovus commented 1 year ago

Currently breaking type changes are always reported as invalid. This change skips reporting them when version update permits, similar to deleted paths.

This was likely an oversight when creating the test cases since it was done correctly for path deletions.

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 6935541544


Totals Coverage Status
Change from base Build 6857091638: 0.1%
Covered Lines: 944
Relevant Lines: 1731

💛 - Coveralls
wenovus commented 1 year ago

Tested at https://github.com/openconfig/public/actions/runs/6935603515/job/18866072229