search

openconfig / ygnmi

A Go gNMI client library based on ygot-generated code
Apache License 2.0
12 stars 4 forks source link

Feature Request: GNMI Union Replace #124

Closed mojiiba closed 1 year ago

mojiiba commented 1 year ago

Could you please add support for GNMI Union Replace. The detail for gnmi union replace is described here: https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-union_replace.md

greg-dennis commented 1 year ago

Heh, @wenovus fixed this very quickly earlier today in https://github.com/openconfig/ygnmi/pull/123 What's left for Ondatra support:

  1. Pull this new ygnmi version into google3
  2. Add wrapper functions to Ondatra for BatchUnionReplace and BatchUnionReplaceCLI
  3. Push a new version of Ondatra externally
  4. Update featureprofiles deps to require the new Ondatra version

I am going on vacation for two weeks starting on Monday morning. @wenovus, can you take it from here?

wenovus commented 1 year ago

Sure I can take a look.

wenovus commented 1 year ago

Featureprofiles PR at https://github.com/openconfig/featureprofiles/pull/2018

mojiiba commented 1 year ago

thanks a lot!