Unique alert names - Githubissues

opendatahub-io / opendatahub-operator

Open Data Hub operator to manage ODH component integrations

https://opendatahub.io

Apache License 2.0

62 stars 144 forks source link

Unique alert names #1397

Closed jackdelahunt closed 1 day ago

jackdelahunt commented 2 days ago

Description

Give unique names to alerts to give more info about what is firing

How Has This Been Tested?

make test-alerts

Screenshot or short clip

Merge criteria

[x] You have read the contributors guide.
[x] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
[x] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (rhoai@55fd878). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## rhoai #1397 +/- ## ======================================== Coverage ? 18.87% ======================================== Files ? 30 Lines ? 3338 Branches ? 0 ======================================== Hits ? 630 Misses ? 2639 Partials ? 69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StevenTobin commented 1 day ago

/lgtm

jackdelahunt commented 1 day ago

Added the changes needs for rhods after rebase, and also had to sign commits so need lgtm again

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/opendatahub-io/opendatahub-operator/blob/rhoai/OWNERS)~~ [grdryn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

grdryn commented 1 day ago

and also had to sign commits

Is that a requirement?

jackdelahunt commented 1 day ago

and also had to sign commits

Is that a requirement?

When I was making a pr into the component refactor it wasn't but for this branch it is apparently.

Not sure if it is new or just for this