opendcs / opendcs

Open Data Collection System for Hydro/Meteorologic Data
Apache License 2.0
38 stars 27 forks source link

Water Temp Profile DAO #1095

Open oskarhurst opened 1 month ago

oskarhurst commented 1 month ago

Is your feature request related to a problem? Please describe. Initializing, saving, and reading large sets of timeseries data for water temp profiles is computationally intensive.

Describe the solution you'd like Investigate the creation of a WTP DAO or a timeseries profile DAO to better handle database operations to minimize database requests and connection needed to use profile data.

Describe alternatives you've considered The current alternative that is being used, it to read and write each profile one at a time from timeseries seperated by a unique location string for depth.

Additional context There are two paths forward, one create a WTP DAO which handles multiple timeseries batched read and writes on the existing WTP format. The second it to resturcture the WTP to use the new timeseries profile database object and create a more universal timeseries profile DAO.

MikeNeilson commented 1 month ago

Re additional context:

It makes sense in code to actually create a formal TS Profile structure. with CWMS we can then map almost directly to it. For other implementations that design provides a target for implementation and usage.

So I would go with the "more universal time series profile DAO"