search

opendomeco / nativescript-auto-fit-text

{N} Plugin to resize text to fit with
Apache License 2.0
13 stars 6 forks source link

Adding the option to leave it as it is if the actual text size fits the space #2

Open demetrio812 opened 6 years ago

demetrio812 commented 6 years ago

Hello, I'm testing the plugin in Android and it's very useful (thank you!), the only problem is caused to me by this line:

textField.setTextSize(200);

This will alway try to make the text to the maximum size available, that is cool, but it doesn't consider the label height so in real life layout it make the component unusable.

For example let's say I have a name that most of the time fits the available space but I want to lower the font only in case it doesn't: with that text size size it will alway try to use the available space, so if the name is very small it will become massive.

If we remove that line the current font size is kept and it will start resizing only if the text doesn't fit.

Hopefully I've explained the issue :)

Is it possible to have this 2 ways as an option to pass to the component?

Do you agree with this? I can send a pull request as soon as I have a bit of free time if you agree

Cheers, Dem

danielgek commented 6 years ago

Hi, @demetrio812 i understand the problem(someone on slack also told me something similar), i'm happy to accept PR's ;)

gabrielsmelo commented 5 years ago

Any update about this issue? Would be nice to have the option to leave the size as it is, and lower only in the case it doesn't fit.