unit testing - Githubissues

openearth / glofrim

Globally Applicable Framework for Integrated Hydrological-Hydrodynamic Modelling (GLOFRIM)

GNU General Public License v3.0

46 stars 27 forks source link

unit testing #78

Open DirkEilander opened 6 years ago

DirkEilander commented 6 years ago

it's obvious we need unit testing. so just do it!

JannisHoch commented 6 years ago

[x] Update model_test_data and remove unnecessary files (esp. forcing)
[ ] Make unit tests for coupled and stand-alone BMI runs (@DirkEilander ), working with lean model test data repos
[x] Clean up "tests" folder
[ ] Copy lean version of model_test_data/test_Elbe to glofrim

JannisHoch commented 6 years ago

@DirkEilander @hii600 I have removed some 47 files from the model_test_data repository in a new branch named "lean".

PCR forcing is therefore not available anymore and needs to be provided via BMI.

DirkEilander commented 5 years ago

We need to distinguish between unit testing and integration/regression testing. Right now the tests are using the unit testing framework but are mostly doing integration tests. Read more about the difference here https://github.com/anfema/integrate#whats-the-difference-between-integration-testing-and-unit-testing

JannisHoch commented 5 years ago

@DirkEilander just checking - do we need this issue still as we already have implemented some water balance checks for the water volume exchange between models?

DirkEilander commented 5 years ago

yes. this is all but finished...