Closed ansabgillani closed 2 years ago
Seems fine to me. But just a question here, should not this include other parts of repository like helper methods and stuff. Also, there are some test files under authn_mfe folder. Just confirming with you?
@aghaawais01 All other tests/files were checked and verified except the one test mentioned on top. All other tests were fine in regards of the scope of this
keyword.
As per investigations in the usage of cypress as an e2e test, it was found that a majority of the current test code was. using
this
keyword to create variables, which, according to cypress's documentation, was not the best practice. A follow-up ticket was created to mitigate the use of thethis
keyword according to cypress's best practices. Here, I have addressed the following issues:this
keyword in the cypress test.test_bulk_code_management.spec.js
were failing. They still require an update with the above-mentioned improvements.PROD-2529
For reference, the best practices for cypress variables and aliases can be accessed here.