openedx / frontend-app-authoring

Front-end for the Open edX Studio experience, implemented in React and Paragon.
GNU Affero General Public License v3.0
14 stars 78 forks source link

"Manage Users/Permissions" for v2 Libraries #1342

Open bradenmacdonald opened 2 months ago

bradenmacdonald commented 2 months ago

Need product/UX requirements here.

Describe how to access this panel - in a tab of the library info sidebar?

Backend notes

Here is what is already implemented on the backend:

There are no org-level permissions.

Users can be added to the team of each library, in one of three roles:

Global staff are like admins on all libraries.

There are also two settings that each library has (only admins can change):

bradenmacdonald commented 2 months ago

@jmakowski1123 Please add the product/UX requirements here :)

pomegranited commented 1 month ago

@jmakowski1123 CC @bradenmacdonald

FYI until the full design is ready, I'm starting with a modal based on the existing Course Team UI:

image

pomegranited commented 1 month ago

Hi @jmakowski1123 @lizc577 @sdaitzman @marcotuts I've deployed my Draft https://github.com/openedx/frontend-app-authoring/pull/1362 to the tagging-preview sandbox.

Could someone take a look and let me if anything needs changing for MVP? I could use your input on the UX and text I chose.

To access the new Library Team modal:

  1. Select a library from the list of v2 Libraries, and open the Library Info sidebar.
  2. If you have Admin access to that library (or are Global Staff), you should see a "Manage Access" button, where you can add/remove team members and change their access levels.
  3. If you only have Author access to the library, you can only view the Library Team, not make changes.
  4. If you only have Read access to a library, you cannot view the Library Team (and won't see a "Manage Access" button at all).
ChrisChV commented 1 week ago

Hi @jmakowski1123 @lizc577 @sdaitzman @marcotuts friendly reminder that this is ready for AC testing on the sandbox

sdaitzman commented 1 week ago

Looks good to me overall! I think it would make sense to examine the right-side button interface in a future update, and consider switching to a dropdown. I think this is a reasonable approach to take for now.

I did notice that when using the button to add a new team member, the error that appears when adding a non-registered user ("Error adding team member") is nonspecific. Would it be possible to add a description like "Check that the email is entered correctly, and corresponds to a registered user" or similar? Or, could we add a specific "User not found" error (is there any security issue in this logged-in admin context)?

image