Open kdmccormick opened 1 year ago
The "Known Issues" list as of right now was based on some initial discovery by @nedbat . We have not yet checked the dependencies of the default frontend-apps.
Also: We have not checked the dep lists for course-discovery, ecommerce, and other release-tagged IDAs. Tthis is OK, because none of those IDAs are run by default in the named release.
I think you might want to add https://github.com/edx/mongoid-tree, which is used by https://github.com/openedx/cs_comments_service
refs:
Or may be not, because forum is not run by defualt...
I've added a check to edx-repo-health to ensure all main repos are in the correct organization: https://github.com/openedx/edx-repo-health/pull/340
Thanks Ned!
Hi folks! Is there something we could help you with so we can move this forward?
@nedbat , had you been working on a script to check whether dependencies of released repos are in the openedx org? Or was that just for top-level released repos?
I worked on it back in December: https://github.com/openedx/repo-tools/blob/master/edx_repo_tools/find_dependencies/README.rst
Nice, thanks @nedbat .
@mariajgrimaldi this issue remains important, but I think everyone involved is just busy right now. I'm not sure if Feanil or Ned plan on picking up it; if not, I'd probably be able to work more on it in July-ish.
I think the next step is to re-run Ned's script and get a concrete list of all the repos that are outside the openedx
organization. Once that's done we can ticket each one individually and start picking them off as it makes sense. I'm in the same boat as Kyle and can't spend a lot of time on it now but @mariajgrimaldi if you have time to do that and update this ticket with the findings, that would be a great help.
Do you folks still need help with this? I've now allocated the time for it -- sorry for the delay!
@mariajgrimaldi no worries. If you have time and are interested in working on this, then certainly we could still use the help!
I re-ran the dependency analyzer last week and got these results:
BUT: Ed noticed that ora2 isn't mentioned. We aren't yet analyzing dependencies that get installed via other mechanisms. We still have some work to do on the analyzer.
Thanks @nedbat.
By "other mechanisms" I assumed you mean things like EDXAPP_PRIVATE_REQUIREMENTS, but ora2 is installed in base.txt: https://github.com/openedx/edx-platform/blob/ddb092c07c6e2b663dc3d52e7197b42f7f017988/requirements/edx/base.txt#L776
Yeah, I'm digging into this now. I don't understand why ora2 doesn't end up in the results yet.
Updated results (from this repo-tools fix):
Hmm, there are still some missing repos because some don't declare their URL in their metadata:
Repo URL is UNKNOWN in files/openedx_django_wiki-2.0.1-py3-none-any.whl
No repo URL in files/staff_graded_xblock-2.1.1-py3-none-any.whl
Repo URL is UNKNOWN in files/pynliner-0.8.0-py2.py3-none-any.whl
Repo URL is UNKNOWN in files/xblock_poll-1.13.0-py3-none-any.whl
No repo URL in files/django_multi_email_field-0.7.0-py3-none-any.whl
No repo URL in files/shapely-2.0.1-cp38-cp38-macosx_10_9_x86_64.whl
Repo URL is UNKNOWN in files/done_xblock-2.1.0-py3-none-any.whl
No repo URL in files/xblock_drag_and_drop_v2-3.2.0-py3-none-any.whl
No repo URL in files/click_didyoumean-0.3.0-py3-none-any.whl
Repo URL is UNKNOWN in files/xblock_google_drive-0.4.0-py2.py3-none-any.whl
Repo URL is UNKNOWN in files/edx_user_state_client-1.3.2-py3-none-any.whl
(I think the difference between "No repo URL" and "Repo URL is UNKNOWN" is due to how the packages are built?)
I've made some pull requests to add the URL to our packages. Thumbs appreciated:
I don't if this also releavnt while working on something I found a dependency in frontend-app-learning called frontend-lib-learning-assistant
ref in pacakge.json whichs exits in edx https://github.com/edx/frontend-lib-learning-assistant
Context
Starting with Palm, if a repo is in the named release, then its first-party dependencies must be in the openedx GH org.
More details: https://discuss.openedx.org/t/interim-guidance-on-the-openedx-github-organization/8518
This is related to, but not the same as: https://github.com/openedx/build-test-release-wg/issues/203
Known issues
Deps to edx-platform:
Deps to default frontend-apps (learning, account, gradebook, profile, authn, discussions, course-authoring):
Acceptance Criteria
Write tooling to find all offending dependencies.
Then, for each dependency, either:
openedx
org; or