openemr / openemr

The most popular open source electronic health records and medical practice management solution.
https://open-emr.org/
GNU General Public License v3.0
3.2k stars 2.16k forks source link

Remove jquery-ui project overview #2999

Open bradymiller opened 4 years ago

bradymiller commented 4 years ago

Describe the problem

jquery-ui is nearing the end of its road

Describe the solution you'd like

Remove jquery-ui

This issue will only be used to list related sub-issues. They are listed below, and will create separate issues for them (complicated ones will get their own issues, while will bundle the less complicated ones into issues).

  1. Change help_files modal to use bootstrap instead of jquery-ui (interface/help_modal.php) https://github.com/openemr/openemr/issues/3000
  2. Change registration modal (login and about gui) to use bootstrap instead of jquery-ui https://github.com/openemr/openemr/issues/3001
  3. Change encounter tabs from jquery-ui to bootstrap https://github.com/openemr/openemr/issues/3002
  4. Remove jquery-ui from interface/clickmap/template/general_new.html script (and related library/js/clickmap.js) https://github.com/openemr/openemr/issues/3003
  5. Change jquery-ui tooltip to bootstrap tooltip in interface/billing/sl_eob_search.php script https://github.com/openemr/openemr/issues/3004
  6. Change jquery-ui tooltip to bootstrap tooltip in interface/orders/types.php script https://github.com/openemr/openemr/issues/3004
  7. Change jquery-ui tooltip to bootstrap tooltip in interface/usergroup/adminacl.php script https://github.com/openemr/openemr/issues/3004
  8. Remove jquery-ui from the Fees->'EDI History' module https://github.com/openemr/openemr/issues/3005
  9. Remove jquery-ui from admin.php script https://github.com/openemr/openemr/issues/3006
  10. Remove jquery-ui from custom/download_qrda.php script https://github.com/openemr/openemr/issues/3006
  11. Remove jquery-ui from interface/billing/search_payments.php script https://github.com/openemr/openemr/issues/3006
  12. Remove jquery-ui from interface/billing/ub04_form.php script https://github.com/openemr/openemr/issues/3006
  13. Remove jquery-ui from interface/code_systems/dataloads_ajax.php script https://github.com/openemr/openemr/issues/3006
  14. Remove jquery-ui from interface/drugs/add_edit_drug.php script https://github.com/openemr/openemr/issues/3007
  15. Remove jquery-ui from interface/fax/fax_dispatch.php script https://github.com/openemr/openemr/issues/3007
  16. Remove jquery-ui from interface/forms/LBF/new.php script https://github.com/openemr/openemr/issues/3007
  17. Remove jquery-ui from interface/forms/eye_mag/SpectacleRx.php script https://github.com/openemr/openemr/issues/3007
  18. Remove jquery-ui from interface/forms/eye_mag/a_issue.php script https://github.com/openemr/openemr/issues/3007
  19. Remove jquery-ui from interface/forms/eye_mag/view.php script https://github.com/openemr/openemr/issues/3007
  20. Remove jquery-ui from interface/forms/fee_sheet/new.php script https://github.com/openemr/openemr/issues/3008
  21. Remove jquery-ui from interface/forms/group_attendance/new.php script https://github.com/openemr/openemr/issues/3008
  22. Remove jquery-ui from interface/forms/newpatient/common.php script https://github.com/openemr/openemr/issues/3008
  23. Remove jquery-ui from interface/main/messages/messages.php script https://github.com/openemr/openemr/issues/3008
  24. Remove jquery-ui from interface/main/pwd_expires_alert.php script https://github.com/openemr/openemr/issues/3008
  25. Remove jquery-ui from interface/main/tabs/main.php script https://github.com/openemr/openemr/issues/3008
  26. Remove jquery-ui from interface/new/new_comprehensive.php script https://github.com/openemr/openemr/issues/3008
  27. Remove jquery-ui from interface/orders/procedure_provider_edit.php script https://github.com/openemr/openemr/issues/3008
  28. Remove jquery-ui from interface/orders/single_order_results.php script https://github.com/openemr/openemr/issues/3008
  29. Remove jquery-ui from interface/orders/types_edit.php script https://github.com/openemr/openemr/issues/3008
  30. Remove jquery-ui from interface/patient_file/encounter/superbill_custom_full.php script https://github.com/openemr/openemr/issues/3009
  31. Remove jquery-ui from interface/patient_file/front_payment.php script https://github.com/openemr/openemr/issues/3009
  32. Remove jquery-ui from interface/patient_file/merge_patients.php script https://github.com/openemr/openemr/issues/3009
  33. Remove jquery-ui from interface/patient_file/summary/add_edit_issue.php script https://github.com/openemr/openemr/issues/3009
  34. Remove jquery-ui from interface/patient_file/summary/immunizations.php script https://github.com/openemr/openemr/issues/3009
  35. Remove jquery-ui from interface/patient_file/summary/pnotes_full.php script https://github.com/openemr/openemr/issues/3009
  36. Remove jquery-ui from interface/patient_tracker/patient_tracker.php script https://github.com/openemr/openemr/issues/3009
  37. Remove jquery-ui from interface/therapy_groups/therapy_groups_views/header.php script https://github.com/openemr/openemr/issues/3009
  38. Remove jquery-ui from interface/usergroup/facilities.php script https://github.com/openemr/openemr/issues/3009
  39. Remove jquery-ui from interface/usergroup/facility_admin.php script https://github.com/openemr/openemr/issues/3009
  40. Remove jquery-ui from interface/usergroup/facility_user.php script https://github.com/openemr/openemr/issues/3010
  41. Remove jquery-ui from interface/usergroup/facility_user_admin.php script https://github.com/openemr/openemr/issues/3010
  42. Remove jquery-ui from interface/usergroup/usergroup_admin.php script https://github.com/openemr/openemr/issues/3010
  43. Remove jquery-ui from interface/weno/ajax_sample_code.php script https://github.com/openemr/openemr/issues/3010
  44. Remove jquery-ui from interface/weno/confirm.php script https://github.com/openemr/openemr/issues/3010
  45. Remove jquery-ui from library/custom_template/custom_template.php script https://github.com/openemr/openemr/issues/3010
  46. Remove jquery-ui from library/custom_template/personalize.php script https://github.com/openemr/openemr/issues/3010
  47. Remove jquery-ui from portal/patient/templates/OnsiteDocumentListView.tpl.php script https://github.com/openemr/openemr/issues/3011
  48. Remove jquery-ui from portal/patient/templates/_FormsHeader.tpl.php script https://github.com/openemr/openemr/issues/3011
  49. Remove jquery-ui from setup.php script https://github.com/openemr/openemr/issues/3011
  50. Remove jquery-ui from src/OeUI/OemrUI.php script https://github.com/openemr/openemr/issues/3011
  51. Remove jquery-ui from templates/documents/general_list.html script https://github.com/openemr/openemr/issues/3011
  52. Remove jquery-ui from templates/prescription/general_edit.html script https://github.com/openemr/openemr/issues/3011
stu01509 commented 4 years ago

Hi @bradymiller I am interested in this work, Please assign me. Also, I would like to put part of remove jquery-UI in my GSoC proposal.

bradymiller commented 4 years ago

hi @stu01509 , Am breaking it down into reasonable chunks (see the following issues). Just request assigning in those and then I'll assign you. The reason we aren't making it one project is to prevent stress and early aging; @tywrenn 's lifespan potentially was decreased here :) https://github.com/openemr/openemr/pull/2927

stu01509 commented 4 years ago

hi @stu01509 , Am breaking it down into reasonable chunks (see the following issues). Just request assigning in those and then I'll assign you. The reason we aren't making it one project is to prevent stress and early aging; @tywrenn 's lifespan potentially was decreased here :) #2927

OK, waiting for your good news.

bradymiller commented 4 years ago

btw @stu01509 , having jquery-ui removal as part of a code modernization GSoC proposal makes good sense. I'd be really surprised if we are able to do this all before GSoC projects start (ie. there should be lots of this still to do at that time).

bradymiller commented 4 years ago

ok, all the issues are ready. ask on the issue and you shall receive :)

stu01509 commented 4 years ago

@bradymiller

Can I pick many issues? If not, Please assign me issue #3004. Thank you :)

bradymiller commented 4 years ago

Sure, you can pick as much as you want (would rec not doing more than several at a time, but it is your lifespan :) ). Gotta add you to the OpenEMR team to see you on the Assignees selector if no posts yet (invitation going out now).

stu01509 commented 4 years ago

Hi @bradymiller,

I has been joined the OpenEMR team, So I can choose an issue and assign myself?

bradymiller commented 4 years ago

hi @stu01509 , Github is a bit wacky on this stuff. Being on the team allows me to assign you without you posting a message on the issue. Otherwise you would of needed to post a message on the issue before I can assign you. To be able to assign on the issue requires write access to the repo (or at least it did a year ago when I looked into it; I'll look into that again). I just assigned you #3004 . -brady

tywrenn commented 4 years ago

This still needs to be done -- hopefully @im-Amitto can fix this still

stu01509 commented 4 years ago

If @im-Amitto didn't want to work, I would like to try to fix it 😁.

im-Amitto commented 4 years ago

@stu01509 If you want it. be my guest :) I currently have 3 pull requests 1-> PR #3055 2 -> PR #3027 3 -> PR #3024 Most of the basic stuff is already completed in the mentioned PR but yet not completed. Let me know which one you wanna pick first and I will close my PR and you can use it as a reference and can raise a new one.

P.S. I am also resuming my work on those so faster you pick one will be better for me.

stu01509 commented 4 years ago

Hello @im-Amitto

I would like to try #3055 first, Thank you :)