search

openenclave / oeedger8r-cpp

An implementation of oeedger8r in C++
MIT License
8 stars 13 forks source link

Remove corelibc #76

Closed anakrish closed 3 years ago

anakrish commented 3 years ago

corelibc declarations are not compatible with declarations in standard headers on various platforms. This causes compile errors when oeedger8r is compiled on Alpine. Corelibc symbols oe_strlen, oe_wcslen, oe_errno needed to compile generated code are defined without bringing in all of corelibc.

Note: corelibc will likely be a problem when OE SDK is compiled on Alpine Linux.

Also change %lS to standards compliant %ls

Signed-off-by: Anand Krishnamorthi anakrish@microsoft.com

oe-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anakrish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openenclave/oeedger8r-cpp/blob/master/OWNERS)~~ [anakrish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anakrish commented 3 years ago

/retest

mingweishih commented 3 years ago

/lgtm

anakrish commented 3 years ago

/retest

oe-ci-robot commented 3 years ago

@anakrish: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pr-oeedger8r-cpp-Ubuntu1804BuildClang-8 9e06e083185800e1fe3de218106c57557d2be2eb link /test pr-oeedger8r-cpp-Ubuntu1804BuildClang-8
pr-oeedger8r-cpp-Ubuntu1604BuildClang-8 9e06e083185800e1fe3de218106c57557d2be2eb link /test pr-oeedger8r-cpp-Ubuntu1604BuildClang-8
pr-oeedger8r-cpp-Rhel8BuildClang-8 9e06e083185800e1fe3de218106c57557d2be2eb link /test pr-oeedger8r-cpp-Rhel8BuildClang-8
pr-oeedger8r-cpp-Windows2016Build 9e06e083185800e1fe3de218106c57557d2be2eb link /test pr-oeedger8r-cpp-Windows2016Build
pr-oeedger8r-cpp-Windows2019Build 9e06e083185800e1fe3de218106c57557d2be2eb link /test pr-oeedger8r-cpp-Windows2019Build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by opening an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
BRMcLaren commented 3 years ago

Ignore me.

/retest

BRMcLaren commented 3 years ago

/test all