search

openequella / moodle-mod_openEQUELLA

Moodle module for integration with openEQUELLA
https://openequella.github.io/moodle-mod_openEQUELLA/
GNU General Public License v3.0
6 stars 16 forks source link

Fix UUID schema error #77

Closed yao9394 closed 2 years ago

yao9394 commented 4 years ago
Checklist
Description of change

76

edalex-ian commented 4 years ago

Hello @yao9394

Thank you very much for you contribution. We'll review it shortly.

Could you please advise whether have or if you're able to to sign the contributor license agreement? Apereo requires this before contributions can be accepted. (If you have already done so, the process is quick and painless.)

yao9394 commented 4 years ago

Hello @yao9394

Thank you very much for you contribution. We'll review it shortly.

Could you please advise whether have or if you're able to to sign the contributor license agreement? Apereo requires this before contributions can be accepted. (If you have already done so, the process is quick and painless.)

Hi @edalex-ian , thanks. I have just signed the agreement

edalex-ian commented 4 years ago

Thanks @yao9394 . Please let us know when you've received acceptance. :)

ChristianMurphy commented 3 years ago

@edalex-ian the ICLA is now listed on http://licensing.apereo.org, under the GitHub tab, thanks @yao9394!

edalex-ian commented 3 years ago

Heya @SammyIsConfused

As we look towards a 1.2 for #80 , could you please review and validate this?

Thank you.

PenghaiZhang commented 3 years ago

Thanks @yao9394 for this PR. I am trying to validate this fix but I have some questions here.

  1. In #76, you mentioned for plugin users who installed this plugin before this version 2011072600. However, as far as I know, this plugin requires Moodle 2.7 and up. Moodle 2.7 was released in 2014. So how can plugin users install this plugin with a Moodle version released in 2011 ?

  2. What version of this plugin were you using when you had this issue ?

  3. What version of Moodle were you using ?

  4. Looks like you wanted to use CHAR as the type of field uuid . However, I found the type of uuid has been CHAR since the initial commit. :thinking: What is the uuid definition in your install.xml?

  5. What database (and the db version) were you using for Moodle ?

  6. Were you using Equella 6.6 or 6.5 or other newer version ?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.