search

openequella / openEQUELLA

Core openEQUELLA sources
https://openequella.github.io/
Apache License 2.0
42 stars 44 forks source link

OAI harvester isn't picking up noSetHierarchy errors #1711

Closed mrblippy closed 4 years ago

mrblippy commented 4 years ago

Describe the bug When oEQ harvester makes a request to an OAI repository, it's supposed to pick up any errors, log the error, and display it to the user.

One of the possible error codes that can be returned is 'noSetHierarchy'. But the oEQ harvester is checking for errors it's looking for the code looking for the code 'noSetHierarchyException'. According to the OAI protocol site oEQ is in the wrong.

So we should fix it, so the user can see clearly why their harvester isn't returning results.

Code that needs to be changed: https://github.com/openequella/openEQUELLA/blob/c9941d45ef6f8e598521993b408ea7ffd843a36b/Source/Plugins/Core/com.equella.core/src/com/tle/core/harvester/oai/verb/Verb.java#L155

To Reproduce Steps to reproduce the behavior:

  1. Import this Harvester profile Agrega2 - LOMES.zip
  2. Open the Harvester Profile
  3. Click on the 'Actions' tab, then click the 'Test!' button
  4. A dialog will appear saying 'Found 0 resources' Capture2

Expected behavior If the OAI request has errored, the error message should be shown in the dialog: Capture

Platform:

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.