search

openeuropa / epoetry-client

PHP client for the ePoetry service.
European Union Public License 1.2
2 stars 2 forks source link

EWPP-3132: Upgrade library to Symfony 5 and 6. #53

Closed ademarco closed 1 year ago

drupol commented 1 year ago

This is perfect for Symfony 6.

I have some questions:

  1. Do you think we could relax some deps to allow Symfony 5 as well? The client who asked this library in first place is using Symfony 5.
  2. Just for my own information, what is the benefits of using ~6 instead of ^6 in this particular case?
ademarco commented 1 year ago
  1. I'm actually finalizing it also for Symfony 5.5
  2. I don't believe there is any difference when only specifying a major constraint, as in: no minor, no patch
drupol commented 1 year ago

Nailed it !

drupol commented 1 year ago

Copying the comment from the other thread in here.

About the branches, shouldn't it be a better option to branch off to 1.x and use the main branch for the most recent development ?

ademarco commented 1 year ago

About branches: we prefer having 1.x and 2.x.

drupol commented 1 year ago

About branches: we prefer having 1.x and 2.x.

Fair enough. That said, I'm curious to know what you're going to have in main branch then ?

ademarco commented 1 year ago

We will not use master at the end, we will just have 1.x and 2.x

drupol commented 1 year ago

Ok good to know!

drupol commented 1 year ago

What's wrong with PHP 8.0 ? Tests were passing fine, no?

ademarco commented 1 year ago

Latest version of https://github.com/phpro/soap-client doesn't support it.

EC-Hugo-SOMBREIREIRO commented 1 year ago

Hi, We're waiting on Symfony 5 / PHP 8 support to be implemented so we can use the client on our project (that needs to go live soon). Any idea when the PRs will be merged? Thanks.

drupol commented 1 year ago

Great! Thank you guys!