I have fixed hypnos such that it builds and works despite underlying formatting issues in petrarch2. Neither the petrarch2 or corenlp sub-containers are modified.
Petrarch2 output dictionary fields were poorly formed (tuple keys) that caused json.dumps to fail.
Petrarch2 function _format_parsed_str wasn't being called prior to do_coding.
Hypnos docker should now build properly and the example code works properly. I changed the example in the readme because Petrarch2 was not identifying events in the previous example. However, the examples given in the Petrarch2 unit tests work as expected.
The output format is slightly modified to correct for Petrarch2's poorly formatted output, but I anticipate that it will be backwards compatible with the previous output format for all (at least most) applications.
I have fixed hypnos such that it builds and works despite underlying formatting issues in petrarch2. Neither the petrarch2 or corenlp sub-containers are modified.
Hypnos with Petrarch2 was breaking (see https://github.com/openeventdata/hypnos/issues/4#issue-222910790). This was due, in part, to the following remediated errors:
json.dumps
to fail._format_parsed_str
wasn't being called prior todo_coding
.Hypnos docker should now build properly and the example code works properly. I changed the example in the readme because Petrarch2 was not identifying events in the previous example. However, the examples given in the Petrarch2 unit tests work as expected.
The output format is slightly modified to correct for Petrarch2's poorly formatted output, but I anticipate that it will be backwards compatible with the previous output format for all (at least most) applications.