openfaas / ofc-bootstrap

Bootstrap OpenFaaS Cloud for your team
https://docs.openfaas.com/openfaas-cloud/intro/
MIT License
179 stars 61 forks source link

Update OFC Authorization code to avoid depreciation of GitHub API calls #219

Closed Waterdrips closed 4 years ago

Waterdrips commented 4 years ago

https://github.com/openfaas/openfaas-cloud/pull/664

We need to bump OFC version once the above is merged and released so our Github users don't install a version with deprecated GitHub Authorization API calls

Expected Behaviour

use the above version

Current Behaviour

current version will stop working on 1st Oct

Possible Solution

besirkurtulmus commented 4 years ago

When I try to create a new installation, it seems that I'm getting an empty token from the github auth server.

I'm wondering if anyone else is having this issue?

wilsonianb commented 4 years ago

I think an updated github-status Docker image needs to pushed with the changes that resolve this issue (https://github.com/openfaas/openfaas-cloud/pull/664).

alexellis commented 4 years ago

@besirkurtulmus this is the first time we've heard from you. Glad you are finding OpenFaaS Cloud useful, what are you doing with it?

alexellis commented 4 years ago

/set title: Update OFC Authorization code to avoid depreciation of GitHub API calls

besirkurtulmus commented 4 years ago

@besirkurtulmus this is the first time we've heard from you. Glad you are finding OpenFaaS Cloud useful, what are you doing with it?

Trying to use it for audio processing. Got the basic installation working, but still trying to get the cloud version working.

Do you have a timeline for updating the github-status image/function?

Specifically because I couldn't figure out how to create a custom github-status docker image.

Waterdrips commented 4 years ago

/close

this is done