Closed viveksyngh closed 3 years ago
I think we should have added enable_ingress_operator
as ingress_operator: true/false
.. so I think that might be why you named this filed accordingly.
Could you put openfaas_operator: true/false
instead? defaulting to false
.
Let's change the ingress option at the same time?
setting these values to true/false
wouldn't cause issue while users try to deploy without editing it ?
They are already true/false values. The operator is new, so not a concern and AFAIK nobody is using the Ingress Operator with OFC, in which case keeping its default of false will have no mal effects.
Just to clarify, I'm just asking for you to rename the variables to remove the enable_ suffix.
Updated
This commit adds field
enable_openfaas_operator
to deploy OpenFaaS with operatorSigned-off-by: Vivek Singh vivekkmr45@yahoo.in
Description
How Has This Been Tested?
I have tested this on my local k3s cluster with this repo with crd deployed https://github.com/viveksyngh/openfaas-functions/runs/1562603783
Checklist:
I have:
git commit -s