openfaas / ofc-bootstrap

Bootstrap OpenFaaS Cloud for your team
https://docs.openfaas.com/openfaas-cloud/intro/
MIT License
179 stars 61 forks source link

Add field to enable openfaas operator #246

Closed viveksyngh closed 3 years ago

viveksyngh commented 3 years ago

This commit adds field enable_openfaas_operator to deploy OpenFaaS with operator

Signed-off-by: Vivek Singh vivekkmr45@yahoo.in

Description

How Has This Been Tested?

I have tested this on my local k3s cluster with this repo with crd deployed https://github.com/viveksyngh/openfaas-functions/runs/1562603783

k get crd
NAME                        CREATED AT
addons.k3s.cattle.io        2020-12-16T08:28:16Z
helmcharts.helm.cattle.io   2020-12-16T08:28:16Z
functions.openfaas.com      2020-12-16T08:29:28Z
profiles.openfaas.com       2020-12-16T08:29:28Z
sealedsecrets.bitnami.com   2020-12-16T08:30:10Z
tunnels.inlets.inlets.dev   2020-12-16T08:31:48Z

Checklist:

I have:

alexellis commented 3 years ago

I think we should have added enable_ingress_operator as ingress_operator: true/false.. so I think that might be why you named this filed accordingly.

Could you put openfaas_operator: true/false instead? defaulting to false.

alexellis commented 3 years ago

Let's change the ingress option at the same time?

viveksyngh commented 3 years ago

setting these values to true/false wouldn't cause issue while users try to deploy without editing it ?

alexellis commented 3 years ago

They are already true/false values. The operator is new, so not a concern and AFAIK nobody is using the Ingress Operator with OFC, in which case keeping its default of false will have no mal effects.

alexellis commented 3 years ago

Just to clarify, I'm just asking for you to rename the variables to remove the enable_ suffix.

viveksyngh commented 3 years ago

Updated