openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
281 stars 227 forks source link

PHP version update #266

Closed Shikachuu closed 3 years ago

Shikachuu commented 3 years ago

Signed-off-by: Shikachuu zcmate@gmail.com

Description

To mostly maintain backward compatibility I update the images to PHP 7.4 to keep the php7 name. Update PHP version everywhere to 7.4, changed composer flag to :1 to always use the most up-to-date composer:1 version. (I also added type hints to the Handler class, but that's not the main topic of this pull request, so it can be removed if there is a need.)

Motivation and Context

The reason behind this PR is that PHP 7.2 is EOL since 2020 November and composer was way down in security patches.

Which issue(s) this PR fixes

How Has This Been Tested?

Since it is just a version bump in the Dockerfile I just ran a Docker build command to check for complications.

Types of changes

Impact to existing users

Checklist: