openfaas / templates

OpenFaaS Classic templates
https://www.openfaas.com
MIT License
281 stars 227 forks source link

Garden does not allow openfaas templates after openfaas/templates#1.2 #297

Closed haljac closed 2 years ago

haljac commented 2 years ago

Garden does not currently support of-watchdog based language templates in its openfaas plugin. Attempts to use newer templates such a node16 result in a failed lookup: image

Upon examining the source code, it appears that in core/src/plugins/openfaas/openfaas.ts (line 110) the version for the templates is pegged to release 1.2 (from Aug 02, 2019).

I'm opening this issue to investigate whether there are any repercussions to removing this cap and allowing for the new templates.

Expected Behaviour

When utilizing lang: node16 in a garden manifest for container type openfaas, correct template should be located in .garden/builds..... and an exception is not thrown.

Current Behaviour

Garden is unable to locate the template.

Are you a GitHub Sponsor (Yes/No?)

Not a github sponsor. My team is using garden extensively for our development purposes and plan to utilize it in production. Open to making contributions in this future and we be happy to start by submitting this small fix if the team feels it's safe.

Check at: https://github.com/sponsors/openfaas

List All Possible Solutions and Workarounds

Just lift the version constraint. Again, I'm not aware of limitations that the team might know.

Which Solution Do You Recommend?

See above

Steps to Reproduce (for bugs)

  1. Create a module of type openfaas with a correctly configured provider (faasNetes.install: true) and use lang: node16.
  2. garden deploy.
  3. Observe exception.

Context

Your Environment