Fix name in package.json for node20 template (#313)

juliancasaburi commented 2 weeks ago

Description

Renamed the template from openfaas-node18 to openfaas-node20 in package.json.

Motivation and Context

This change is required to prevent confusion, as the current template name openfaas-node18 does not correctly represent the Node.js version. Renaming the template to openfaas-node20 aligns it with the correct Node.js version.

[x] I have raised an issue to propose this change (Issue #313)

Which issue(s) this PR fixes

Fixes #313

How Has This Been Tested?

The change was reviewed by verifying the updated name field in package.json. No other functionality is affected by this change, so no additional testing was required.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Impact to existing users

None, as this change only affects the template name for clarity.

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide.
[x] I have signed-off my commits with git commit -s.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

derek[bot] commented 2 weeks ago

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

:bulb: Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name" git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force. If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

rgee0 commented 2 weeks ago

/close : fixed in https://github.com/openfaas/templates/commit/5aa87c3e4e9a29732a4674a84bb0688f4789d3c1

openfaas / templates