Open bdeclerc opened 7 years ago
I'm getting a more problematic behaviour... with workbench moderation. Following the video, until minute 5 everything looks ok but the table already has a difference: the EN version title is updated with "eng fwd" for vid = 4.
When I reproduce the step at minute 5 (publishing FR node), I don't get the same behaviour but instead both EN/FR version get published After that, if we edit either EN or FR we are not able to create drafts anymore! It means that even if we save as Draft, the latest revision will always be the published version, ignoring the workflow state.
Issue for workbench moderation https://www.drupal.org/node/2768615 although I guess the issue will be fixed here https://www.drupal.org/node/2766957 and a patch will be ported.
We're still a way away from actually taking Economie/Statbel into production so we do have some margin to find & implement fixes or workaround - it is a bit worrying that stuff as fundamental is this is open :(
From: Ruben Marques notifications@github.com Sent: 03 May 2017 17:24:18 To: openfed/openfed8 Cc: Bart Declercq; Author Subject: Re: [openfed/openfed8] Content Moderation and Entity Translations + Multilingual worries (#30)
Issue for workbench moderation https://www.drupal.org/node/2768615 although I guess the issue will be fixed here https://www.drupal.org/node/2766957 and a similar patch will be created.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/openfed/openfed8/issues/30#issuecomment-298945130, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEv6TMyMFyWds360g24PWhSvot5a98Ppks5r2JwigaJpZM4NMjC2.
I think this may be a solution https://github.com/dawehner/content_translation_worfklow
It basically copies all your forward revisions ahead of the default revision.
On 3 May 2017 at 17:33, Bart notifications@github.com wrote:
We're still a way away from actually taking Economie/Statbel into production so we do have some margin to find & implement fixes or workaround - it is a bit worrying that stuff as fundamental is this is open :(
From: Ruben Marques notifications@github.com Sent: 03 May 2017 17:24:18 To: openfed/openfed8 Cc: Bart Declercq; Author Subject: Re: [openfed/openfed8] Content Moderation and Entity Translations
- Multilingual worries (#30)
Issue for workbench moderation https://www.drupal.org/node/2768615 although I guess the issue will be fixed here https://www.drupal.org/node/ 2766957 and a similar patch will be created.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ openfed/openfed8/issues/30#issuecomment-298945130, or mute the thread< https://github.com/notifications/unsubscribe-auth/ AEv6TMyMFyWds360g24PWhSvot5a98Ppks5r2JwigaJpZM4NMjC2>.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/openfed/openfed8/issues/30#issuecomment-298947991, or mute the thread https://github.com/notifications/unsubscribe-auth/AEuI7ooWGctzyLzkWOXw-QStPMTFaMsRks5r2J5agaJpZM4NMjC2 .
Worth a try - smells a bit like what's done in Wb 3.0 for D7 where it's confusing as heck, but the consequences of not doing it are less severe there.
From: Stefan Ruijsenaars notifications@github.com Sent: Wednesday, May 3, 2017 5:49:32 PM To: openfed/openfed8 Cc: Bart Declercq; Author Subject: Re: [openfed/openfed8] Content Moderation and Entity Translations + Multilingual worries (#30)
I think this may be a solution https://github.com/dawehner/content_translation_worfklow
It basically copies all your forward revisions ahead of the default revision.
On 3 May 2017 at 17:33, Bart notifications@github.com wrote:
We're still a way away from actually taking Economie/Statbel into production so we do have some margin to find & implement fixes or workaround - it is a bit worrying that stuff as fundamental is this is open :(
From: Ruben Marques notifications@github.com Sent: 03 May 2017 17:24:18 To: openfed/openfed8 Cc: Bart Declercq; Author Subject: Re: [openfed/openfed8] Content Moderation and Entity Translations
- Multilingual worries (#30)
Issue for workbench moderation https://www.drupal.org/node/2768615 although I guess the issue will be fixed here https://www.drupal.org/node/ 2766957 and a similar patch will be created.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ openfed/openfed8/issues/30#issuecomment-298945130, or mute the thread< https://github.com/notifications/unsubscribe-auth/ AEv6TMyMFyWds360g24PWhSvot5a98Ppks5r2JwigaJpZM4NMjC2>.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/openfed/openfed8/issues/30#issuecomment-298947991, or mute the thread https://github.com/notifications/unsubscribe-auth/AEuI7ooWGctzyLzkWOXw-QStPMTFaMsRks5r2J5agaJpZM4NMjC2 .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/openfed/openfed8/issues/30#issuecomment-298952662, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEv6TIf2p4kLxDlOeww1Axq66pX2_AHmks5r2KIMgaJpZM4NMjC2.
I just tested the module and it seems to fix the issue and everything works as expected. Stefan, do you know if there are any plans for a module on d.org or to include it on WB module?
(Putting this in the right project)
An interesting bit from Tim Millwood: http://www.millwoodonline.co.uk/blog/content-moderation-content-translation-crazy
While we're still using Workbench Moderation, I'm wondering if the same fundamental issue doesn't apply there also? We may need to test this and warn the clients of this possibility.