fix: don't attempt to import tuples if none are present

openfga / cli

A cross-platform CLI to interact with an OpenFGA server

https://openfga.dev

Apache License 2.0

50 stars 26 forks source link

fix: don't attempt to import tuples if none are present #408

Closed ap0calypse8 closed 1 month ago

ap0calypse8 commented 1 month ago

Description

References

Fixes #368

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[x] I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

linux-foundation-easycla[bot] commented 1 month ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: ap0calypse8 / name: Anirban Pal (fe3f1c8c94d35ddd8f7734ae24e98614372a5287, 220d3cedabc7453ff458fe787cc7d8741e5579d6, 8b96c42e9722ccd0fc03c20a3028f8a247e15304, 70ce9d654d46e38a73b79254cf13c1220010a24b, d230f187a0a05579f56d574d120429a2ade104a3, 7e2a50935d5acf3b57dc1ca5b05ac663ad67d4f9)

ap0calypse8 commented 1 month ago

To summarize the changes: We added a check for len(storeData.Tuples) == 0 after initializing the FGA client. 2. If there are no tuples, we print a message and return the response immediately. The progress bar initialization and tuple import process only occur if there are tuples to import. This should resolve the issue you're experiencing while still allowing the model to be imported successfully

ap0calypse8 commented 1 month ago

You can review and help me out with running the tests.

ap0calypse8 commented 1 month ago

hey any update from the side of the reviewer?

ap0calypse8 commented 1 month ago

you are welcome!