search

openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.
https://openfisca.org
GNU Affero General Public License v3.0
170 stars 75 forks source link

Add version and changes check to openfisca command or task manager #1284

Open bonjourmauko opened 1 month ago

bonjourmauko commented 1 month ago

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

I'm normalising the toolbox for maintainers and contributors.

Here is what I expected to happen:

There should be just one tool to do all the checks required to contribute.

Here is what actually happened:

There are different sh files across several repositories.

These should all be handled either by a task manager or by the openfisca command.

Here is data (or links to it) that can help you reproduce this issue:

https://github.com/openfisca/openfisca-core/issues/1040#issuecomment-912527581 https://github.com/openfisca/extension-template/pull/58

MattiSG commented 1 month ago

My intention was to use https://github.com/OpenTermsArchive/changelog-action 🙂

bonjourmauko commented 1 month ago

My intention was to use https://github.com/OpenTermsArchive/changelog-action 🙂

TBH, these checks have little to do in the dev tool (Makefile, Taskfile, etc.). Go for it.

bonjourmauko commented 4 weeks ago

BTW I've use python-semantic-release in another project and works quite effortlessly: https://github.com/openfisca/openfisca-setup-builder/blob/main/.github/workflows/default.yaml#L63