openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.
https://openfisca.org
GNU Affero General Public License v3.0
170 stars 75 forks source link

revert: restore line printing in tracer #1304

Open guillett opened 2 days ago

guillett commented 2 days ago

Fixes #1310

Technical changes

bonjourmauko commented 2 days ago

Hi! Was this a bug introduced recently? I'd love to add a failing test for this. If you could point me out at how to reproduce the error and the expected behaviour, I could help with the test.

guillett commented 2 days ago

Thanks @bonjourmauko , I don't have much time to follow up. To me, this is a regression and I need this fix to work locally.

bonjourmauko commented 2 days ago

@guillett If you give me the command you normally use I can propose you a stacked PR with the proposed fix.

Concerning print, even if I accept it, you won't be able to merge this PR because of the linter.

bonjourmauko commented 2 days ago

Oh nevermind, I see the regression was introduced here https://github.com/openfisca/openfisca-core/commit/2f8072fdf270bfd204f1103b227a893f80a3bdaa#diff-fc2477fbba8037857fb9287895920ee5a1015c5eda4edb50832af14232fdd10b