Proof: allow editing the location

[serpico]

What

No location field when editing proof.

Steps to reproduce the behavior:

Went to dashboard > My Proof > Filter > Hide proofs with prices and found a proof without location ( maybe it's a rare case or the issue that generated the missing location has been solved, in that case I'm ok dismissing/closing the issue )

Clicked to make the Edit card appear, Clicked on Edit in the menu.

I don't see a field to change, in that case, add the location.

Expected behavior

Something allowing to change or add a location, preferably using OSM id

Screenshots

Platform (Desktop, Mobile, Hunger Games)

• OS: Linux
• Platform : Laptop

[raphodn]

linked with #689

[raphodn]

In the first versions of the app (and in the mobile integration until quite recently), the proof did not have any location data (nor date & currency). I can run a script to fill this data if there is at least 1 price attached to it. But for proofs without prices, it's impossible automatically..

Indeed, if the proof has 0 prices, then everything should be editable...

[serpico]

I added a price to that particular proof, funnily it used the last location I used as a "default value". Feel free to ping me after running the script so I can try to edit...although I think we can't edit location yet even for "errorless" proof.

[raphodn]

Ah that's an issue..

It's this price right ? https://prices.openfoodfacts.org/app/prices/36477

I can fix it manually, then re-run the script

[serpico]

this one https://prices.openfoodfacts.org/app/products/3364699014104

[raphodn]

i had a look on OSM, there seems to be 2 Tang Frères in that neighborhood ^^

you've added prices for https://prices.openfoodfacts.org/app/locations/419 (https://www.openstreetmap.org/node/2621636797) but maybe it's the other one ? https://www.openstreetmap.org/node/252814154 :sweat_smile:

[raphodn]

I ran the scripts :ok_hand: (222 proofs without locations, but with at least 1 price) (and attached the price & the proof to the location you already used)

fyi it's this script : https://github.com/openfoodfacts/open-prices/wiki/Useful-scripts#fix-proofs-without-locations but I'm going to put in the code + regular CRON. edit: done here: https://github.com/openfoodfacts/open-prices/pull/481

[serpico]

i had a look on OSM, there seems to be 2 Tang Frères in that neighborhood ^^

you've added prices for https://prices.openfoodfacts.org/app/locations/419 (https://www.openstreetmap.org/node/2621636797) but maybe it's the other one ? https://www.openstreetmap.org/node/252814154 😅

You're the man !!! good catch !!! Yeah I remember it was the early days and I struggled with Komoot's results...😅

it's definitely 252814154, if you can transfer all there, I'll clean up the light bulb which is another mistake after :)

[serpico]

https://prices.openfoodfacts.org/app/locations/420 all these are in fact 252814154 ( OSM id ) as well, don't know I you can do something, or we can wait till we're a little further along in the possibly for users to amend their contributions, it's a good use case for testing those features

[raphodn]

ok no worries :) I have a small utility script to help move a proof's location (and its attached prices), i just did it for both 419 & 420. They are now here : https://prices.openfoodfacts.org/app/locations/1113 (except your lightbulb, the proof seems different from the price)

[serpico]

yeah for 3601029959705 , the light bulb, both the date and location are wrong ( it was me ), what do you think we keep it as is, until registered users are allowed/permitted to change the date and location of a price ? edit 2 : or wait till we have the proof's filter to quickly pin down the correct date's proof ( 19/10/2021 - in that case ), create the price on that proof and finally delete the current price with wrong date and location...

Edit : With the light bulb I tried using Dashboard > My Proofs then order by Proof date, then I scrolled down a shitload of proofs :) down until May 2024 ( the DateChip on the light bulb price shows 10/05/2024 ) but it goes straight from 09/05/2024 to 12/05/2024, I think sorting by addition date will be much trickier....

[raphodn]

until registered users are allowed/permitted to change the date and location of a price

I'd say that edit option (of location & date) would only be available at the proof level. and it would then impact the X prices linked to it. And yeah in #839 we need to find ways for users like you with a LOT of proofs :innocent: (there's also a plan to create thumbnails of proof images, to have this proof list page load/scroll faster. edit: done!)