search

openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
853 stars 282 forks source link

Mixed languages in settings #1673

Closed teolemon closed 2 years ago

teolemon commented 2 years ago

What

image

monsieurtanuki commented 2 years ago

@teolemon That's not very fair to say "Mixed languages in settings", or to call it a bug. More generally, you want to be able to switch languages on your smartphone and that everything on the app changes to the new language: new localizations and refreshed metadata (including products). It's not like smoothie has bugs and is designed to display random language localizations; in a normal use-case (always the same language) this issue does not happen. I understand the logic and the advanced use-case, but it's not a bug alert, it's more an advanced feature requirement.

monsieurtanuki commented 2 years ago

My bad: there was actually an "advanced" bug. If you go from language A to language B to language C, no problem. But then, if you go back to language A or B that doesn't work, we are stuck with language C. Quickly said: the reason why that we had already dowloaded and stored locally the preferences, and that the values didn't change between what was stored and what we've just downloaded: no change, no refresh. I've just added a test "if we changed languages, force refresh". In a PR, very very soon.