openfoodfacts / smooth-app

🤳🥫 The new Open Food Facts mobile application for Android and iOS, crafted with Flutter and Dart
https://world.openfoodfacts.org/open-food-facts-mobile-app?utm_source=off&utf_medium=web&utm_campaign=github-repo
Apache License 2.0
862 stars 286 forks source link

Grey screen in production (Build 1241) from Oct 26 (ingredients) #4780

Open teolemon opened 1 year ago

teolemon commented 1 year ago

What

monsieurtanuki commented 1 year ago

Fixed by #4705 (4.11.0, https://github.com/openfoodfacts/smooth-app/commit/34f33640f70e0b263e457db886c3922bd8af4404)

g123k commented 1 year ago

It seems the issue is not fixed by the PR. Version 1241 was released on the 26th of October VS the PR was merged on the 08th

monsieurtanuki commented 1 year ago

@g123k You may be right as I don't understand 100% of the release process, but on the OP screenshot the version is 4.9.2 and the PR was included in 4.11.0. In addition to that, I tested with or without the PR, and I got a grey screen without it (actually a red one with a null pointer exception as it was in debug mode). Of course there could be other reasons for a grey screen, but a null pointer exception for a null brand looks very tempting. Feel free to close this issue again if my arguments make sense.

g123k commented 1 year ago

As I'm not 100% sure, @teolemon : could you generate a new internal build and ensure it's based on the 4.11.x, please?

teolemon commented 1 year ago

I've pushed a build, but based on the dates on what was previously in production, and the commits I have reviewed, I don't believe we have a fix @monsieurtanuki @g123k

monsieurtanuki commented 1 year ago

@teolemon @g123k Therefore the github details are perhaps misleading: Capture d’écran 2023-11-15 à 10 15 59