openforcefield / openff-benchmark

Comparison benchmarks between public force fields and Open Force Field Initiative force fields
MIT License
10 stars 2 forks source link

[WIP] Add error route for molecules in optimize export #62

Closed j-wags closed 3 years ago

j-wags commented 3 years ago

Description

This PR is an alternative solution to #58. I think it's safer, since it covers a wider range of possible issues. However I'm a bit concerned because I can't test it.

Todos

dotsdl commented 3 years ago

Thanks for putting this together @j-wags; I like your solution, and will review this tomorrow and work to address the concerns you have raised.

j-wags commented 3 years ago

I'm going to close this PR, in favor of consolidating the error handling logic in the PR where we handle proton transfer.